Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(tap-agent): remove false positives #248

Merged
merged 2 commits into from
Jul 9, 2024
Merged

test(tap-agent): remove false positives #248

merged 2 commits into from
Jul 9, 2024

Conversation

gusinacio
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9846728785

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 65.809%
Files with Coverage Reduction New Missed Lines %
tap-agent/src/agent/sender_allocation.rs 1 85.05%
Totals Coverage Status
Change from base Build 9814764823: 0.01%
Covered Lines: 3836
Relevant Lines: 5829
💛 - Coveralls

aasseman
aasseman previously approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio merged commit f37cf7f into main Jul 9, 2024
10 checks passed
@gusinacio gusinacio deleted the gusinacio/test-update-wait branch July 9, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasseman aasseman aasseman approved these changes

Assignees

@gusinacio gusinacio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gusinacio @aasseman